Difference between revisions of "BIP 0016 QA"

From Bitcoin Wiki
Jump to: navigation, search
 
(10 intermediate revisions by 4 users not shown)
Line 1: Line 1:
−
This page is a Quality Assurance test plan for BIPs 17.  If you see a test missing, please add it.
+
This page is a Quality Assurance test plan for [[BIP 16]].  If you see a test missing, please add it.
 
If you can help test, please edit this page to sign-off on it.
 
If you can help test, please edit this page to sign-off on it.
  
 
{| class="wikitable"
 
{| class="wikitable"
 
|-
 
|-
−
! Testnet !! Mainnet !! Test Procedure !! Tested by
+
! Done !! Test Procedure !! Tested by
  
−
|- style="color:red;"
+
|- style="color:green;"
−
| ||
+
| ✓
−
| Run BIP-17-capable Bitcoin 0.6 on testnet and main net<br />
+
| Run BIP-16-capable Bitcoin 0.6 on testnet and main net<br />
−
Send coins using GUI, RPC sendtoaddress, and RPC sendmany commands<br />
+
Send coins using GUI, RCP sendtoaddress, and RCP sendmany commands<br />
 
Result: coins sent in all cases
 
Result: coins sent in all cases
−
|  
+
| Gavin Andresen
  
−
|- style="color:lime;"
+
|- style="color:green;"
−
| &#x2713; || &#x2713;
+
| &#x2713;
 
| Test multisig 1-of-1<br />
 
| Test multisig 1-of-1<br />
 
Run 0.6 bitcoind, get a public key with: ./bitcoind -testnet validateaddress $(./bitcoind -testnet getnewaddress)<br />
 
Run 0.6 bitcoind, get a public key with: ./bitcoind -testnet validateaddress $(./bitcoind -testnet getnewaddress)<br />
Line 21: Line 21:
 
Result: transaction is confirmed by network, displays properly in listtransactions.
 
Result: transaction is confirmed by network, displays properly in listtransactions.
 
Result: balance is unaffected
 
Result: balance is unaffected
−
| Luke Dashjr
+
| Gavin Andresen; see transactions in [http://blockexplorer.com/testnet/block/000000001bdceba3936f2ea6a55311ac7b6030e327f1960e892620fcde6abf5f testnet block 44989]
 +
 
  
−
|- style="color:red;"
+
|- style="color:green;"
−
| ||
+
| &#x2713;
 
| Test multisig 1-of-2<br />
 
| Test multisig 1-of-2<br />
 
Run 0.6 bitcoind, get 2 new bitcoin addresses<br />
 
Run 0.6 bitcoind, get 2 new bitcoin addresses<br />
Line 31: Line 32:
 
Result: transaction is confirmed by network, displays properly in listtransactions.
 
Result: transaction is confirmed by network, displays properly in listtransactions.
 
Result: bitcoin balance is unaffected.
 
Result: bitcoin balance is unaffected.
−
|  
+
| Gavin Andresen; see transactions in [http://blockexplorer.com/testnet/block/000000001bdceba3936f2ea6a55311ac7b6030e327f1960e892620fcde6abf5f testnet block 44989]
 +
 
  
−
|- style="color:red;"
+
|- style="color:green;"
−
| ||
+
| &#x2713;
 
| Test multisig 1-of-3, 2-of-3, 3-of-3<br />
 
| Test multisig 1-of-3, 2-of-3, 3-of-3<br />
 
Repeat test procedures above, with the other new multisignature transaction types
 
Repeat test procedures above, with the other new multisignature transaction types
−
|  
+
| Gavin Andresen; see transactions in [http://blockexplorer.com/testnet/block/000000001bdceba3936f2ea6a55311ac7b6030e327f1960e892620fcde6abf5f testnet block 44989]
  
−
|- style="color:red;"
+
|- style="color:green;"
−
| ||
+
| &#x2713;
 
| Test multisig send-to-other<br />
 
| Test multisig send-to-other<br />
 
Repeat test procedures above, but use two bitcoinds, prepared as follows:<br />
 
Repeat test procedures above, but use two bitcoinds, prepared as follows:<br />
Line 49: Line 51:
 
Result: balance for 2 goes down, listtransactions for 2 displays correct result<br />
 
Result: balance for 2 goes down, listtransactions for 2 displays correct result<br />
 
Result: balance for 1 goes up, listtransactions for 1 displays correct result<br />
 
Result: balance for 1 goes up, listtransactions for 1 displays correct result<br />
−
|  
+
| Gavin Andresen; see transactions in [http://blockexplorer.com/testnet/block/000000001bdceba3936f2ea6a55311ac7b6030e327f1960e892620fcde6abf5f testnet block 44989]
 +
 
  
−
|- style="color:red;"
+
|- style="color:green;"
−
| ||
+
| &#x2713;
 
| Test redeeming multisignature transactions<br />
 
| Test redeeming multisignature transactions<br />
 
Fund a new, empty wallet entirely with multisig transactions<br />
 
Fund a new, empty wallet entirely with multisig transactions<br />
Line 60: Line 63:
 
Result: transactions are accepted/confirmed by network<br />
 
Result: transactions are accepted/confirmed by network<br />
 
Result: balance decreases, listtransactions displays correct information<br />
 
Result: balance decreases, listtransactions displays correct information<br />
−
|  
+
| Gavin Andresen; see transactions in [http://blockexplorer.com/testnet/block/000000001bdceba3936f2ea6a55311ac7b6030e327f1960e892620fcde6abf5f testnet block 44989]
 +
 
  
−
|- style="color:red;"
+
|- style="color:green;"
−
| ||
+
| &#x2713;
 
| Run 0.6 Bitcoin-Qt GUI on one of the test wallets from above<br />
 
| Run 0.6 Bitcoin-Qt GUI on one of the test wallets from above<br />
 
Result: balance and transactions displayed correctly
 
Result: balance and transactions displayed correctly
−
|
+
| Gavin Andresen
  
−
|- style="color:red;"
+
|- style="color:orange;"
−
| ||
+
| &#x2713;
−
| Run BIP-17-capable backport Bitcoin 0.3.19 through 0.5.1<br />
+
| Run BIP-16-capable backport Bitcoin 0.3.19 through 0.5.1 on testnet and main net<br />
−
Send coins using GUI, RPC sendtoaddress, and RPC sendmany commands<br />
+
Send coins using GUI, RCP sendtoaddress, and RCP sendmany commands<br />
 
Result: coins sent in all cases
 
Result: coins sent in all cases
−
|  
+
| Gavin Andresen (tested 0.3.19, 0.3.24 and 0.5.1)
  
−
|- style="color:red;"
+
|- style="color:green;"
−
| || n/a
+
| &#x2713;
−
| Run BIP-17-capable Bitcoin 0.6.0<br />
+
| Run BIP-16-capable Bitcoin 0.6.0 on testnet<br />
 
Mine coins using built-in miner<br />
 
Mine coins using built-in miner<br />
−
Result: blocks accepted, show up on pre-BIP17 clients<br />
+
Result: blocks accepted, show up on blockexplorer.com/testnet<br />
−
Result: mined blocks' coinbase contains p2sh/CHV string
+
Result: mined blocks' coinbase contains /P2SH/ string
−
|  
+
| Gavin Andresen
  
−
|- style="color:red;"
+
|- style="color:green;"
−
| &#x2713; ||
+
| &#x2713;
−
| Run BIP-17-capable Bitcoin 0.6.0<br />
+
| Run BIP-16-capable Bitcoin 0.6.0 on testnet<br />
 
Mine coins using getwork interface<br />
 
Mine coins using getwork interface<br />
−
Result: blocks accepted, show up on pre-BIP17 clients<br />
+
Result: blocks accepted, show up on blockexplorer.com/testnet<br />
−
Result: mined blocks' coinbase contains p2sh/CHV string
+
Result: mined blocks' coinbase contains /P2SH/ string
−
|  
+
| Gavin Andresen
  
−
|- style="color:red;"
+
|- style="color:green;"
−
| ||
+
|
−
| Run BIP-17-capable Bitcoin 0.6.0<br />
+
| Run BIP-16-capable Bitcoin 0.6.0 on testnet<br />
 
Mine coins using getmemorypool interface<br />
 
Mine coins using getmemorypool interface<br />
−
Result: blocks accepted, show up on pre-BIP17 clients<br />
+
Result: blocks accepted, show up on blockexplorer.com/testnet<br />
−
Result: mined blocks' coinbase contains p2sh/CHV string
+
Result: mined blocks' coinbase contains /P2SH/ string
−
|  
+
| Gregory Maxwell; Using p2pool see [https://blockexplorer.com/testnet/rawblock/00000000040367fcb750b6f064db6955b6c7c6218fb625e3dfed6b5c19c97107 testnet block 45400] (and many others, also tested on mainnet)
  
−
|- style="color:red;"
+
|- style="color:green;"
−
| ||
+
| &#x2713;
−
| Run BIP-17-capable Bitcoin 0.3.19 through 0.5.1 backports<br />
+
| Run BIP-16-capable Bitcoin 0.3.19 through 0.5.1 backports on testnet<br />
 
Mine coins using built-in miner<br />
 
Mine coins using built-in miner<br />
−
Result: blocks accepted, show up on pre-BIP17 clients<br />
+
Result: blocks accepted, show up on blockexplorer.com/testnet<br />
−
Result: mined blocks' coinbase contains p2sh/CHV string
+
Result: mined blocks' coinbase contains /P2SH/ string
−
|  
+
| Gavin Andresen (tested all on a testnet-in-a-box)
  
−
|- style="color:red;"
+
|- style="color:green;"
−
| ||
+
| &#x2713;
−
| Run BIP-17-capable Bitcoin 3.19 through 0.5.1 backports on testnet<br />
+
| Run BIP-16-capable Bitcoin 3.19 through 0.5.1 backports on testnet<br />
 
Mine coins using getwork interface<br />
 
Mine coins using getwork interface<br />
−
Result: blocks accepted, show up on pre-BIP17 clients<br />
+
Result: blocks accepted, show up on blockexplorer.com/testnet<br />
−
Result: mined blocks' coinbase contains p2sh/CHV string
+
Result: mined blocks' coinbase contains /P2SH/ string
−
|  
+
| Gavin Andresen (tested all on a testnet-in-a-box)
  
−
|- style="color:red;"
+
|- style="color:green;"
−
| ||
+
| &#x2713;
−
| Run BIP-17-capable Bitcoin 0.3.19 through 0.5.1 backports on testnet<br />
+
| Run BIP-16-capable Bitcoin 0.3.19 through 0.5.1 backports on testnet<br />
 
Mine coins using built-in miner<br />
 
Mine coins using built-in miner<br />
−
Result: blocks accepted, show up on pre-BIP17 clients<br />
+
Result: blocks accepted, show up on blockexplorer.com/testnet<br />
−
Result: mined blocks' coinbase contains p2sh/CHV string
+
Result: mined blocks' coinbase contains /P2SH/ string
−
|  
+
| Gavin Andresen (tested all on a testnet-in-a-box)
  
 +
|- style="color:green;"
 +
| &#x2713;
 +
| Run BIP-16-capable Bitcoin 3.19 through 0.5.1 backports on testnet<br />
 +
Mine coins using getwork interface<br />
 +
Result: blocks accepted, show up on blockexplorer.com/testnet<br />
 +
Result: mined blocks' coinbase contains /P2SH/ string
 +
| Gavin Andresen (tested all on a testnet-in-a-box)
 
|- style="color:red;"
 
|- style="color:red;"
−
| ||
 
−
| Run BIP-17-capable Bitcoin 3.19 through 0.5.1 backports on testnet<br />
 
−
Mine coins using getwork interface<br />
 
−
Result: blocks accepted, show up on pre-BIP17 clients<br />
 
−
Result: mined blocks' coinbase contains p2sh/CHV string
 
−
|
 
  
 
|- style="color:red;"
 
|- style="color:red;"
−
| ||
+
|
−
| Run BIP-17-capable Bitcoin 3.19 through 0.5.1 backports on testnet<br />
+
| Run BIP-16-capable Bitcoin 3.19 through 0.5.1 backports on testnet<br />
 
Mine coins using getmemorypool interface<br />
 
Mine coins using getmemorypool interface<br />
−
Result: blocks accepted, show up on pre-BIP17 clients<br />
+
Result: blocks accepted, show up on blockexplorer.com/testnet<br />
−
Result: mined blocks' coinbase contains p2sh/CHV string
+
Result: mined blocks' coinbase contains /P2SH/ string
 
|  
 
|  
  
−
|- style="color:red;"
+
|- style="color:green;"
−
| ||
+
| &#x2713;
 
| Create/run unit tests for:<br />
 
| Create/run unit tests for:<br />
 
multisignature signing/verification<br />
 
multisignature signing/verification<br />
Line 146: Line 151:
 
multisignature IsStandard() success/failure<br />
 
multisignature IsStandard() success/failure<br />
 
extraction of addresses from multisignature transactions<br />
 
extraction of addresses from multisignature transactions<br />
−
BIP 17 IsStandard() success/failure<br />
+
BIP 16 IsStandard() success/failure (including failure with OP_PUSHDATA1/2/4)<br />
−
BIP 17 AreInputsStandard() success/failure<br />
+
BIP 16 AreInputsStandard() success/failure<br />
−
BIP 17 compatibility with other 3 standard transaction types<br />
+
BIP 16 compatibility with other 3 standard transaction types<br />
−
BIP 17 switchover date logic<br />
+
BIP 16 no-recursion test<br />
−
|  
+
BIP 16 switchover date logic<br />
 +
OP_CHECKMULTISIG counting of signature operations inside BIP 16 transactions<br />
 +
| Gavin Andresen (see test/multisig_tests.cpp, test/script_tests.cpp, test/script_P2SH_tests.cpp, test/sigopcount_tests.cpp in the bitcoin source tree; 'make test_bitcoin' in src/ directory to compile)
  
−
|- style="color:red;"
+
|- style="color:green;"
−
| ||
+
| &#x2713;
−
| Create/run 'transaction fuzzer' to stress-test BIP 17 transactions
+
| Create/run 'transaction fuzzer' to stress-test BIP 16 transactions
−
|  
+
| Gavin Andresen (https://github.com/gavinandresen/bitcoin-git/tree/fuzzer , run twice on both testnet-in-a-box and testnet with 100,000 'fuzzed' transactions each test run) Valid fuzzed transactions appeared in (for example) [http://blockexplorer.com/testnet/block/000000001587c859649cea954e921ba4efd77707fb327dd53e122fd7b89636c4 testnet block 44987]
  
−
|- style="color:red;"
+
|- style="color:green;"
−
| ||
+
| &#x2713;
 
| Run Bitcoin 0.6 on main net <br />
 
| Run Bitcoin 0.6 on main net <br />
 
Result: blocks created properly
 
Result: blocks created properly
−
Result: blocks include p2sh/CHV string in their coinbase
+
Result: blocks include /P2SH/ string in their coinbase
−
|
+
| various mining pools
  
−
|- style="color:red;"
+
|- style="color:green;"
−
| ||
+
| &#x2713;
−
| Run BIP 17 vinced_mergedmine backport on main net <br />
+
| Run BIP 16 vinced_mergedmine backport on main net <br />
 
Result: blocks created properly
 
Result: blocks created properly
−
Result: blocks include p2sh/CHV string in their coinbase
+
Result: blocks include /P2SH/ string in their coinbase
−
|  
+
| (Gavin for slush: after bug fixes, running with no issues)<br />
 +
 
 +
|- style="color:green;"
 +
| &#x2713;
 +
| Test chain-split handling on testnet-in-a-box <br />
 +
Create two valid hash, invalid signature transactions in two blocks separated in time on a testnet-in-a-box chain<br />
 +
Run a bitcoind to synchronize with the chain, with -paytoscripthashtime set in between the two blocks<br/>
 +
Result: first transaction/block accepted, second causes a chain split<br/>
 +
Re-run bitcoind with -paytoscripthashtime in the future<br/>
 +
Result: entire chain accepted
 +
| Gavin Andresen: testnet-in-a-box files at: http://www.skypaint.com/bitcoin/bip16chain.tar.gz first half-valid BIP16 transaction at block 2431 (time 1328202835) second at block 2436 (time 1328204241)<br />
  
 
|}
 
|}

Latest revision as of 19:50, 9 March 2012

This page is a Quality Assurance test plan for BIP 16. If you see a test missing, please add it. If you can help test, please edit this page to sign-off on it.

Done Test Procedure Tested by
✓ Run BIP-16-capable Bitcoin 0.6 on testnet and main net

Send coins using GUI, RCP sendtoaddress, and RCP sendmany commands
Result: coins sent in all cases

Gavin Andresen
✓ Test multisig 1-of-1

Run 0.6 bitcoind, get a public key with: ./bitcoind -testnet validateaddress $(./bitcoind -testnet getnewaddress)
Generate a multisig 1-of-1 address: ./bitcoind addmultisigaddress 1 {public key from above}
Send-to-self some bitcoins using that address
Result: transaction is confirmed by network, displays properly in listtransactions. Result: balance is unaffected

Gavin Andresen; see transactions in testnet block 44989


✓ Test multisig 1-of-2

Run 0.6 bitcoind, get 2 new bitcoin addresses
Generate a multisig 1-of-2 address: ./bitcoind addmultisigaddress 1 {address1} {address2}
Send-to-self some bitcoins using that address
Result: transaction is confirmed by network, displays properly in listtransactions. Result: bitcoin balance is unaffected.

Gavin Andresen; see transactions in testnet block 44989


✓ Test multisig 1-of-3, 2-of-3, 3-of-3

Repeat test procedures above, with the other new multisignature transaction types

Gavin Andresen; see transactions in testnet block 44989
✓ Test multisig send-to-other

Repeat test procedures above, but use two bitcoinds, prepared as follows:
bitcoind 1 : Run getnewaddress and addmultisigaddress
bitcoind 2 : Just addmultisigaddress
Send coins from 2 to 1 using the address
Result: transaction is accepted/confirmed by network
Result: balance for 2 goes down, listtransactions for 2 displays correct result
Result: balance for 1 goes up, listtransactions for 1 displays correct result

 Gavin Andresen; see transactions in testnet block 44989


✓ Test redeeming multisignature transactions

Fund a new, empty wallet entirely with multisig transactions
Wait for transactions to confirm
Use sendtoaddress and sendmany to generate spend-from-multisig transactions
Spend to both single-address and multisig address, and test send-to-other and send-to-self
Result: transactions are accepted/confirmed by network
Result: balance decreases, listtransactions displays correct information

 Gavin Andresen; see transactions in testnet block 44989


✓ Run 0.6 Bitcoin-Qt GUI on one of the test wallets from above

Result: balance and transactions displayed correctly

Gavin Andresen
✓ Run BIP-16-capable backport Bitcoin 0.3.19 through 0.5.1 on testnet and main net

Send coins using GUI, RCP sendtoaddress, and RCP sendmany commands
Result: coins sent in all cases

Gavin Andresen (tested 0.3.19, 0.3.24 and 0.5.1)
✓ Run BIP-16-capable Bitcoin 0.6.0 on testnet

Mine coins using built-in miner
Result: blocks accepted, show up on blockexplorer.com/testnet
Result: mined blocks' coinbase contains /P2SH/ string

Gavin Andresen
✓ Run BIP-16-capable Bitcoin 0.6.0 on testnet

Mine coins using getwork interface
Result: blocks accepted, show up on blockexplorer.com/testnet
Result: mined blocks' coinbase contains /P2SH/ string

Gavin Andresen
Run BIP-16-capable Bitcoin 0.6.0 on testnet

Mine coins using getmemorypool interface
Result: blocks accepted, show up on blockexplorer.com/testnet
Result: mined blocks' coinbase contains /P2SH/ string

Gregory Maxwell; Using p2pool see testnet block 45400 (and many others, also tested on mainnet)
✓ Run BIP-16-capable Bitcoin 0.3.19 through 0.5.1 backports on testnet

Mine coins using built-in miner
Result: blocks accepted, show up on blockexplorer.com/testnet
Result: mined blocks' coinbase contains /P2SH/ string

Gavin Andresen (tested all on a testnet-in-a-box)
✓ Run BIP-16-capable Bitcoin 3.19 through 0.5.1 backports on testnet

Mine coins using getwork interface
Result: blocks accepted, show up on blockexplorer.com/testnet
Result: mined blocks' coinbase contains /P2SH/ string

Gavin Andresen (tested all on a testnet-in-a-box)
✓ Run BIP-16-capable Bitcoin 0.3.19 through 0.5.1 backports on testnet

Mine coins using built-in miner
Result: blocks accepted, show up on blockexplorer.com/testnet
Result: mined blocks' coinbase contains /P2SH/ string

Gavin Andresen (tested all on a testnet-in-a-box)
✓ Run BIP-16-capable Bitcoin 3.19 through 0.5.1 backports on testnet

Mine coins using getwork interface
Result: blocks accepted, show up on blockexplorer.com/testnet
Result: mined blocks' coinbase contains /P2SH/ string

Gavin Andresen (tested all on a testnet-in-a-box)
Run BIP-16-capable Bitcoin 3.19 through 0.5.1 backports on testnet

Mine coins using getmemorypool interface
Result: blocks accepted, show up on blockexplorer.com/testnet
Result: mined blocks' coinbase contains /P2SH/ string

✓ Create/run unit tests for:

multisignature signing/verification
multisignature invalid signature failure
multisignature IsStandard() success/failure
extraction of addresses from multisignature transactions
BIP 16 IsStandard() success/failure (including failure with OP_PUSHDATA1/2/4)
BIP 16 AreInputsStandard() success/failure
BIP 16 compatibility with other 3 standard transaction types
BIP 16 no-recursion test
BIP 16 switchover date logic
OP_CHECKMULTISIG counting of signature operations inside BIP 16 transactions

 Gavin Andresen (see test/multisig_tests.cpp, test/script_tests.cpp, test/script_P2SH_tests.cpp, test/sigopcount_tests.cpp in the bitcoin source tree; 'make test_bitcoin' in src/ directory to compile)
✓ Create/run 'transaction fuzzer' to stress-test BIP 16 transactions Gavin Andresen (https://github.com/gavinandresen/bitcoin-git/tree/fuzzer , run twice on both testnet-in-a-box and testnet with 100,000 'fuzzed' transactions each test run) Valid fuzzed transactions appeared in (for example) testnet block 44987
✓ Run Bitcoin 0.6 on main net

Result: blocks created properly Result: blocks include /P2SH/ string in their coinbase

various mining pools
✓ Run BIP 16 vinced_mergedmine backport on main net

Result: blocks created properly Result: blocks include /P2SH/ string in their coinbase

(Gavin for slush: after bug fixes, running with no issues)
✓ Test chain-split handling on testnet-in-a-box

Create two valid hash, invalid signature transactions in two blocks separated in time on a testnet-in-a-box chain
Run a bitcoind to synchronize with the chain, with -paytoscripthashtime set in between the two blocks
Result: first transaction/block accepted, second causes a chain split
Re-run bitcoind with -paytoscripthashtime in the future
Result: entire chain accepted

Gavin Andresen: testnet-in-a-box files at: http://www.skypaint.com/bitcoin/bip16chain.tar.gz first half-valid BIP16 transaction at block 2431 (time 1328202835) second at block 2436 (time 1328204241)
Retrieved from "https://tests.bitcoin.it/w/index.php?title=BIP_0016_QA&oldid=24555"