Difference between revisions of "Talk:Protocol documentation"

From Bitcoin Wiki
Jump to: navigation, search
(Error?)
(Errors?)
Line 58: Line 58:
 
https://en.bitcoin.it/wiki/Protocol_specification#version
 
https://en.bitcoin.it/wiki/Protocol_specification#version
  
Under version message there is the field version which has the type of int32_t. Shouldn't it be uint32_t?
+
Under version message there is the field version which has the type of int32_t. Shouldn't it be uint32_t? Same with the start_height.
  
  

Revision as of 18:03, 30 September 2011

Hexdumps

I'm adding some hexdumps of messages and data structures and descriptions of how these are interpreted in order to help others understand these protocol and data structures. It's a bit redundant, so any ideas as to how to remove some of the redundancy while keeping the knowledge accessible are welcome (feel free to make the changes yourself!). -- X6763

Checksum wrong?

Is the checksum in the addr sample correct? Here's what I get using OpenSSL (sorry for long lines): SHA256("\x01\xe2\x15\x10\x4d\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\xff\xff\x0a\x00\x00\x01\x20\x8d") = d6 88 65 c8 20 61 d5 e2 54 52 b5 5b 52 17 98 b1 11 50 85 96 2e 49 e8 fd da b7 f4 fb a3 9c d8 2c and SHA256 of that is ed 52 39 9b 56 8e d8 d5 9a 83 72 9c 11 6f 87 d0 be f2 84 e9 98 f3 47 7c 98 61 16 9a b1 2e ed 5c It could easily be I'm using OpenSSL incorrectly, so wanted to get confirmation -- AndyParkins

- The checksum for "addr" was not working for me neither, and I had the same results "ED 52 39 9B", so I fixed it on the page. --Robert

What is "77x"? Header size wrong?

The description for the headers command says "77x?" as the size for the block_headers[] returned. However, the description of the block_header structure is 81 bytes (4+32+32+4+4+4+1). What exactly is returned by the headers command? -- AndyParkins

Endianess on magic numbers

The given magic numbers are the wrong way around. The magic numbers are little endian 32 bit numbers on the network, so Testnet.Magic = 0xdab5bffa and Prodnet.Magic = 0xd9b4bef9. The two examples are the order they come in from the wire, so at the very least should be shown with spaces between the bytes. AndyParkins

I stumbled upon this as well and corrected the page. --Theo 10:13, 7 June 2011 (GMT)

Version not advertised?

Doing some experiments the version seems to be sent by the client, not the server as I think the page currently says. "When a node receives an incoming connection, it will immediately advertise its version." That is not true. --Bluecmd 10:02, 5 June 2011 (GMT)

You're right, net.h says in CNode constructor: --Theo 10:09, 7 June 2011 (GMT)
       // Be shy and don't send version until we hear
       if (!fInbound)
           PushVersion();

Version in getblocks?

Apparently the official client sends the protocol version in getblocks messages, (possibly even in getheaders). This seems to me to be just weird --Bluecmd 14:57, 6 June 2011 (GMT)

Separate page for hexdumps?

Does anyone else think it may be a good idea to put the hexdumps on a separate page? It'd be nice to have this page just describe the protocol, but at the same time, be able to have examples of each of the different messages and objects. On that node, would it also be helpful if I were to do a hexdump example of all of the different commands/structures? --Andrew12 23:26, 9 June 2011 (GMT)

Proposing additional protocol messages

According to the Bitcoin paper in order to do the simplified verification the client needs to store all headers of the entire chain but needs data only for those blocks that contain transactions of interest.

For this I propose the following new message types:

  • setfilter this message contains a list of bitcoin addresses. After receiving this message on a connection the client will stop broadcasting any inv messages for transactions which don't have a matching address in its inputs or outputs. inv for new blocks will not be filtered.
  • getblocksfiltered this message works exactly like getblocks but it will be answered with a filtered list of only those blocks that contain transactions with unspent outputs matching the filter list.

and the following new inventory type for getdata

  • MSG_BLOCK_PRUNED this will be answered like a MSG_BLOCK but all transactions not matching the filter list and transactions that are already spent will be stripped from the block before transmitting it to the client.

When a client requests such filtering then all new blocks will still be advertised like normal but the client will have the opportunity to request only the absolute minimum necessary data to perform the simplified verification as outlined in the paper and new transactions will only be sent to it if they match the filter list. This should save a LOT of bandwidth. Prof7bit 21:03, 24 June 2011 (GMT)

Errors?

https://en.bitcoin.it/wiki/Protocol_specification#version

Under version message there is the field version which has the type of int32_t. Shouldn't it be uint32_t? Same with the start_height.


https://en.bitcoin.it/wiki/Protocol_specification#Network_address

The hexdump of the network address doesn't seem to have the time field.